Fixed #434: Add null check before accessing integer size #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
tgregg
reviewed
Dec 27, 2023
ion/src/main/java/com/fasterxml/jackson/dataformat/ion/IonParser.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Arthur Chan <[email protected]>
cowtowncoder
changed the title
| try { | ||
| size = _reader.getIntegerSize(); | ||
| } catch (NullPointerException e) { | ||
| // Possible exception |
There was a problem hiding this comment.
Hmmh. I assume this is due to invalid/malformer content; and if so, should error out instead of quietly swallowing. Especially since it will fail couple of lines anyway. I can change that.
…Token.VALUE_NULL`
cowtowncoder
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #434 by adding a null check before accessing the result returning from the
IonReader::getIntegerSize()method and wrap it with a try catch block to handle possibleNullPointerExceptionthrown from underlying logics.